Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: otlp-grpc exporter uses headers environment variables #2304

Merged
merged 4 commits into from
Jun 30, 2021

Conversation

vreynolds
Copy link
Contributor

Which problem is this PR solving?

  • OTLP-gRPC exporter needs to honor the OTEL_EXPORTER_OTLP(*)HEADERS env var
  • from spec:

Key-value pairs to be used as headers associated with gRPC or HTTP requests.

Short description of the changes

  • Merge headers into gRPC exporters' metadata

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #2304 (73dedb9) into main (8f2209f) will not change coverage.
The diff coverage is n/a.

❗ Current head 73dedb9 differs from pull request most recent head e46afa4. Consider uploading reports for the commit e46afa4 to get more accurate results

@@           Coverage Diff           @@
##             main    #2304   +/-   ##
=======================================
  Coverage   92.74%   92.74%           
=======================================
  Files         145      145           
  Lines        5184     5184           
  Branches     1060     1060           
=======================================
  Hits         4808     4808           
  Misses        376      376           

@dyladan dyladan added the enhancement New feature or request label Jun 29, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTEL_EXPORTER_OTLP_HEADERS not honored by gRPC exporter
5 participants