Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: add markdown link checks #2657

Merged
merged 6 commits into from
Dec 11, 2021

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Checks link liveness in markdown.

Type of change

  • Internal facilities

Checklist:

  • Followed the style guidelines of this project

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #2657 (f506667) into main (b804d9b) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2657      +/-   ##
==========================================
- Coverage   93.33%   93.29%   -0.04%     
==========================================
  Files         124      131       +7     
  Lines        4607     4923     +316     
  Branches     1008     1078      +70     
==========================================
+ Hits         4300     4593     +293     
- Misses        307      330      +23     
Impacted Files Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️
...entelemetry-sdk-trace-web/src/WebTracerProvider.ts 100.00% <0.00%> (ø)
...-sdk-trace-web/src/enums/PerformanceTimingNames.ts 100.00% <0.00%> (ø)
...ry-context-zone-peer-dep/src/ZoneContextManager.ts 85.18% <0.00%> (ø)
packages/opentelemetry-sdk-trace-web/src/types.ts 100.00% <0.00%> (ø)
...telemetry-sdk-trace-web/src/StackContextManager.ts 94.28% <0.00%> (ø)
...es/opentelemetry-context-zone-peer-dep/src/util.ts 100.00% <0.00%> (ø)
packages/opentelemetry-sdk-trace-web/src/utils.ts 94.90% <0.00%> (ø)

@legendecas legendecas force-pushed the doc/dead-link-check branch 3 times, most recently from 08aa635 to 5d3da24 Compare December 8, 2021 12:12
@legendecas
Copy link
Member Author

Looks like all david-dm badges are broken.

@legendecas legendecas changed the title chore: add markdown lint checks chore: add markdown link checks Dec 8, 2021
@legendecas
Copy link
Member Author

@dyladan It seems like tag v0.27.0 is missing from the repo and several links in the https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-sdk-metrics-base#work-in-progress are broken.

@legendecas legendecas marked this pull request as ready for review December 8, 2021 16:36
@legendecas legendecas requested a review from a team December 8, 2021 16:36
@dyladan
Copy link
Member

dyladan commented Dec 8, 2021

Looks like all david-dm badges are broken.

david-dm badges are broken all the time. the site is pretty flaky.

@dyladan It seems like tag v0.27.0 is missing from the repo and several links in the main/experimental/packages/opentelemetry-sdk-metrics-base#work-in-progress are broken.

They should be changed to point to experimental/v0.27.0 tag because we have the stable/experimental split now https://github.com/open-telemetry/opentelemetry-js/tree/experimental/v0.27.0

@vmarchaud vmarchaud merged commit f59c5b2 into open-telemetry:main Dec 11, 2021
@legendecas legendecas deleted the doc/dead-link-check branch December 12, 2021 08:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants