Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(instrumentation)!:remove unused description property from interface #4847

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

blumamir
Copy link
Member

@blumamir blumamir commented Jul 3, 2024

As we are talking about stabilizing the @opentelemetry/instrumentation package, I want to suggest removing the description property from Instrumentation interface which is not used anywhere in the codebase (core + contrib).

While this is technically a breaking change, it is very unlikly that someone actually uses it out there IMO.

@blumamir blumamir requested a review from a team July 3, 2024 18:46
@blumamir blumamir changed the title fix(instrumentation):remove unused description property from interface fix(instrumentation)!:remove unused description property from interface Jul 3, 2024
Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. Needs a changelog entry.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pichlermarc pichlermarc added this pull request to the merge queue Jul 4, 2024
Merged via the queue into open-telemetry:main with commit 0f6363a Jul 4, 2024
19 checks passed
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
…ce (open-telemetry#4847)

* fix(instrumentation):remove unused description property from instrumentation ifc

* chore: changelog
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants