Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(resources): fix eslint warning #5383

Merged
merged 3 commits into from
Feb 6, 2025
Merged

refactor(resources): fix eslint warning #5383

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b226519
refactor(resources): fix eslint warning
chancancode Jan 27, 2025
2ba4008
Merge branch 'main' into eslint-warning-resources
chancancode Jan 30, 2025
2edab6f
Merge branch 'main' into eslint-warning-resources
chancancode Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/opentelemetry-resources/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@
* limitations under the License.
*/

export const isPromiseLike = <R>(val: any): val is PromiseLike<R> => {
export const isPromiseLike = <R>(val: unknown): val is PromiseLike<R> => {
return (
val !== null && typeof val === 'object' && typeof val.then === 'function'
val !== null &&
typeof val === 'object' &&
typeof (val as Partial<PromiseLike<R>>).then === 'function'
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding 'then' in val to the existing chain would also work (instead of doing the cast), and sometimes I prefer that for readability. However that does impose a tiny bit of additional runtime cost so I avoided it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-luna resolved

For context: #5350 landed a similar fix so this PR isn't strictly necessary anymore, if the only goal is to get rid of the any (which #5350 did). This is slightly more precise and matches the intention of the code better.

};
Loading