Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(core): drop getEnv(), getEnvWithoutDefaults() #5481

Merged

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Drops getEnv(), getEnvWithoutDefaults() and associated types in favor of the new get*FromEnv() functions introduced in #5443

Fixes #5217

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Unit tests

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.96%. Comparing base (e9d3c71) to head (ed592d2).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5481      +/-   ##
==========================================
- Coverage   94.97%   94.96%   -0.01%     
==========================================
  Files         309      309              
  Lines        8017     7952      -65     
  Branches     1706     1687      -19     
==========================================
- Hits         7614     7552      -62     
+ Misses        403      400       -3     
Files with missing lines Coverage Δ
...pentelemetry-core/src/platform/node/environment.ts 100.00% <ø> (+2.70%) ⬆️
...ckages/opentelemetry-core/src/utils/environment.ts 100.00% <ø> (+3.17%) ⬆️

@pichlermarc pichlermarc added target:next-major-release This PR targets the next major release (`next` branch) pkg:core labels Feb 17, 2025
@pichlermarc pichlermarc added this to the OpenTelemetry SDK 2.0 milestone Feb 17, 2025
@pichlermarc pichlermarc marked this pull request as ready for review February 17, 2025 12:26
@pichlermarc pichlermarc requested a review from a team as a code owner February 17, 2025 12:26
@pichlermarc pichlermarc added this pull request to the merge queue Feb 19, 2025
Merged via the queue into open-telemetry:main with commit faeae98 Feb 19, 2025
20 checks passed
@pichlermarc pichlermarc deleted the feat/drop-getenv branch February 19, 2025 11:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pkg:core target:next-major-release This PR targets the next major release (`next` branch)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] make browser-implementation of getEnv() return only defaults, getEnvWithoutDefaults() an empty object
3 participants