Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Mock httpbin for urllib tests #1845

Closed
ocelotl opened this issue Jun 12, 2023 · 1 comment
Closed

Mock httpbin for urllib tests #1845

ocelotl opened this issue Jun 12, 2023 · 1 comment
Assignees
@ocelotl

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Jun 12, 2023

No description provided.

@ocelotl ocelotl self-assigned this Jun 12, 2023
ocelotl added a commit to ocelotl/opentelemetry-python-contrib that referenced this issue Jun 12, 2023
@ocelotl
Remove usage of httpbin.org

Verified

This commit was signed with the committer’s verified signature.
ocelotl Diego Hurtado
GPG key ID: F6FC8E499358A322
Verified
Learn about vigilant mode
eb58b56 
This is done in order to prevent confusion. Even when the urllib tests
do not make an external request to httpbin.org, having the httpbin.org
URL in our tests is confusing and can give the impression we are
actually using httpbin.org.

Fixes open-telemetry#1845
@ocelotl ocelotl mentioned this issue Jun 12, 2023
Closed
ocelotl added a commit to ocelotl/opentelemetry-python-contrib that referenced this issue Jun 12, 2023
@ocelotl
Remove use of httpbin

Verified

This commit was signed with the committer’s verified signature.
ocelotl Diego Hurtado
GPG key ID: F6FC8E499358A322
Verified
Learn about vigilant mode
da23559 
This is done in order to prevent confusion. We are trying to stop using
httpbin.org for our tests. Even when the tests for the requests
instrumentation do not actually perform any request to httpbin.org,
because the test requests are being mocked somehow having the string
httpbin.org in the tests can cause confusion and make the reader
think the tests are actually making external requests to  httpbin.org.

Fixes open-telemetry#1844 open-telemetry#1843 open-telemetry#1845 open-telemetry#1846 open-telemetry#1847 open-telemetry#1848
@ocelotl ocelotl mentioned this issue Jun 12, 2023
Merged
ocelotl added a commit to ocelotl/opentelemetry-python-contrib that referenced this issue Jun 13, 2023
@ocelotl
Remove use of httpbin

Verified

This commit was signed with the committer’s verified signature.
ocelotl Diego Hurtado
GPG key ID: F6FC8E499358A322
Verified
Learn about vigilant mode
5df0403 
This is done in order to prevent confusion. We are trying to stop using
httpbin.org for our tests. Even when the tests for the requests
instrumentation do not actually perform any request to httpbin.org,
because the test requests are being mocked somehow having the string
httpbin.org in the tests can cause confusion and make the reader
think the tests are actually making external requests to  httpbin.org.

Fixes open-telemetry#1844 open-telemetry#1843 open-telemetry#1845 open-telemetry#1846 open-telemetry#1847 open-telemetry#1848
@shalevr
Copy link
Member

shalevr commented Jun 25, 2023

Fixed here #1854

@shalevr shalevr closed this as completed Jun 25, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove usage of httpbin.org ocelotl/opentelemetry-python-contrib
2 participants
@ocelotl @shalevr