-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Mock httpbin for urllib tests #1845
Comments
ocelotl
added a commit
to ocelotl/opentelemetry-python-contrib
that referenced
this issue
Jun 12, 2023
This is done in order to prevent confusion. Even when the urllib tests do not make an external request to httpbin.org, having the httpbin.org URL in our tests is confusing and can give the impression we are actually using httpbin.org. Fixes open-telemetry#1845
ocelotl
added a commit
to ocelotl/opentelemetry-python-contrib
that referenced
this issue
Jun 12, 2023
This is done in order to prevent confusion. We are trying to stop using httpbin.org for our tests. Even when the tests for the requests instrumentation do not actually perform any request to httpbin.org, because the test requests are being mocked somehow having the string httpbin.org in the tests can cause confusion and make the reader think the tests are actually making external requests to httpbin.org. Fixes open-telemetry#1844 open-telemetry#1843 open-telemetry#1845 open-telemetry#1846 open-telemetry#1847 open-telemetry#1848
Merged
ocelotl
added a commit
to ocelotl/opentelemetry-python-contrib
that referenced
this issue
Jun 13, 2023
This is done in order to prevent confusion. We are trying to stop using httpbin.org for our tests. Even when the tests for the requests instrumentation do not actually perform any request to httpbin.org, because the test requests are being mocked somehow having the string httpbin.org in the tests can cause confusion and make the reader think the tests are actually making external requests to httpbin.org. Fixes open-telemetry#1844 open-telemetry#1843 open-telemetry#1845 open-telemetry#1846 open-telemetry#1847 open-telemetry#1848
Fixed here #1854 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
No description provided.
The text was updated successfully, but these errors were encountered: