Fixing RichConsoleExporter to allow for multiple traces at once #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ocelotl
reviewed
Sep 27, 2022
ocelotl
suggested changes
Sep 28, 2022
exporter/opentelemetry-exporter-richconsole/src/opentelemetry/exporter/richconsole/__init__.py
Outdated
Show resolved
Hide resolved
With a batch exporter this would make all span originate with the first trace Also it would print any span twice which would make the output a bit difficult to read
rbizos
force-pushed
the
fix/rich-console
branch
from
abfe476 to
516cfec
Compare
rbizos
force-pushed
the
fix/rich-console
branch
from
516cfec to
5d1a735
Compare
ocelotl
approved these changes
Oct 3, 2022
|
Please fix |
rbizos
force-pushed
the
fix/rich-console
branch
from
b0e28d5 to
3a4084a
Compare
srikanthccv
reviewed
Oct 7, 2022
…-contrib into fix/rich-console
|
Took some back and forth, sorry about that, I did not spend enough on getting the dev environment to work properly as my feature was so simple. Had some similar issue than #1083. Now that all works it should be better. |
saartochner-lumigo
pushed a commit
to lumigo-io/opentelemetry-python-contrib
that referenced
this pull request
Nov 13, 2022
saartochner-lumigo
pushed a commit
to lumigo-io/opentelemetry-python-contrib
that referenced
this pull request
Nov 13, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes:
This makes the debug of a SDK configuration a bit easier