Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for regular expression matching and sanitizing of headers in FastAPI. #1403

Merged

Conversation

rogersd
Copy link
Contributor

@rogersd rogersd commented Oct 24, 2022

Next part of #1184

Description

Add test cases for regular expression matching.
Add test cases for header sanitizing.
Add documentation for regular expression matching and header sanitation.
Various documentation cleanups and standardization.

Fixes #1184

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit tests added.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@rogersd rogersd requested a review from a team October 24, 2022 18:09
@rogersd rogersd force-pushed the drogers-wildcard-headers-fastapi branch 4 times, most recently from 53dc18e to 6444ecf Compare October 31, 2022 22:37
@rogersd rogersd force-pushed the drogers-wildcard-headers-fastapi branch from 1ae45cc to 73e863f Compare November 7, 2022 16:14
@srikanthccv srikanthccv merged commit 496d658 into open-telemetry:main Nov 7, 2022
saartochner-lumigo pushed a commit to lumigo-io/opentelemetry-python-contrib that referenced this pull request Nov 13, 2022
saartochner-lumigo pushed a commit to lumigo-io/opentelemetry-python-contrib that referenced this pull request Nov 13, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more features for adding HTTP request / response headers to spans.
2 participants