mongo db - fix db statement capturing #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a boolean to decide whether to capture the information or hide it
shalevr
reviewed
Dec 22, 2022
.../opentelemetry-instrumentation-pymongo/src/opentelemetry/instrumentation/pymongo/__init__.py
Outdated
Show resolved
Hide resolved
shalevr
approved these changes
Dec 22, 2022
This was referenced Jan 4, 2023
# Conflicts: # CHANGELOG.md # instrumentation/opentelemetry-instrumentation-pymongo/src/opentelemetry/instrumentation/pymongo/__init__.py # tests/opentelemetry-docker-tests/tests/pymongo/test_pymongo_functional.py
srikanthccv
approved these changes
Jan 21, 2023
10 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix capturing the DB_STATEMENT parameter correctly in mongo db.
Also added an optional value to enable capturing the database statement that is being executed.
Fixes #1462
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?