Skip to content

Audit and test opentelemetry-instrumentation-aiohttp-client NoOpTrace… #1612

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

Akochavi
Copy link
Contributor

Add test for aiohttp-client using NoOpTracerProvider

Fixes #994

How has this been tested?

tox -e test-instrumentation-aiohttp-client

@Akochavi Akochavi requested a review from a team January 30, 2023 13:57
@srikanthccv srikanthccv added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 5, 2023
@Akochavi Akochavi force-pushed the audit-and-test-opentelemetry-instrumentation-aiohttp-client-no-op-tracer branch from 2894b5a to da8b9fb Compare February 5, 2023 07:13
Akochavi and others added 4 commits February 5, 2023 12:27

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…-aiohttp-client-no-op-tracer

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…-aiohttp-client-no-op-tracer

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…-aiohttp-client-no-op-tracer
@srikanthccv srikanthccv enabled auto-merge (squash) February 11, 2023 09:42

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…-aiohttp-client-no-op-tracer

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…-aiohttp-client-no-op-tracer

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…-aiohttp-client-no-op-tracer
@srikanthccv srikanthccv merged commit 0a4b3b4 into open-telemetry:main Feb 13, 2023
shalevr added a commit to shalevr/opentelemetry-python-contrib that referenced this pull request Feb 23, 2023
…/github.com/shalevr/opentelemetry-python-contrib into Change-metrics-tests-to-work-with-test_base

* 'Change-metrics-tests-to-work-with-test_base' of https://github.com/shalevr/opentelemetry-python-contrib:
  Fix issue with Flask instrumentation when a request spawn children threads and copies the request context (open-telemetry#1654)
  Add connection attributes to sqlalchemy connect span (open-telemetry#1608)
  Add boto3sqs to docs (open-telemetry#1666)
  Audit and test opentelemetry-instrumentation-elasticsearch NoOpTracer… (open-telemetry#1616)
  Copy change log updates from release/v1.16.x-0.37bx (open-telemetry#1683)
  Update version to 1.17.0.dev/0.38b0.dev (open-telemetry#1677)
  Fix CI Failure (open-telemetry#1680)
  Add better debugging if hatch subprocess fails (open-telemetry#1672)
  Add confluent kafka docs (open-telemetry#1668)
  Support aio_pika 9 (open-telemetry#1670)
  Audit and test opentelemetry-instrumentation-wsgi NoOpTracerProvider (open-telemetry#1610)
  bot (open-telemetry#1667)
  Add commit method for ConfluentKafkaInstrumentor's ProxiedConsumer (open-telemetry#1656)
  Revert open-telemetry#1097 (open-telemetry#1660)
  Audit and test opentelemetry-instrumentation-django NoOpTracerProvider (open-telemetry#1611)
  Audit and test opentelemetry-instrumentation-aiohttp-client NoOpTrace… (open-telemetry#1612)
  Audit and test opentelemetry-instrumentation-flask NoOpTracerProvider (open-telemetry#1614)
  Audit and test opentelemetry-instrumentation-dbapi NoOpTracerProvider (open-telemetry#1607)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit and test opentelemetry-instrumentation-aiohttp-client
3 participants