Skip to content

Prometheus Remote Write Exporter (4/7) #208

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed

Conversation

AzfaarQureshi
Copy link
Contributor

@AzfaarQureshi AzfaarQureshi commented Nov 23, 2020

Description

This is PR 2/7 of adding a Prometheus Remote Write Exporter in Python SDK and address Issue open-telemetry/opentelemetry-python#1302

Part 1/7

  • Adds class skeleton
  • Adds all function signatures

Part 2/7

  • Adds validation of exporter constructor commands
  • Add unit tests for validation

Part 3/7

  • Adds conversion methods from OTel metric types to Prometheus TimeSeries
  • Add unit tests for conversion

👉 Part 4/7

  • Adds methods to export metrics to Remote Write endpoint
  • Add unit tests for exporting

Part 5/7

  • Add support for optional request parameters (timeout, proxy)
  • Add support for tls config

Part 6/7

  • Add integration tests using sample app and instance of Cortex

Part 7/7

  • Add README, Design Doc and other necessary documentation.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Added class TestValidation in test_prometheus_remote_write_exporter.py

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated (change logs will be updated when PR 7/7 is merged and the RW exporter is complete)
  • Unit tests have been added
  • Documentation has been updated
    cc- @shovnik, @alolita

@AzfaarQureshi AzfaarQureshi requested review from a team, owais and aabmass and removed request for a team November 23, 2020 23:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants