HTTP transition for wsgi #2425
Merged
HTTP transition for wsgi #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocelotl
suggested changes
Apr 16, 2024
opentelemetry-instrumentation/src/opentelemetry/instrumentation/_semconv.py
Outdated
Show resolved
Hide resolved
opentelemetry-instrumentation/src/opentelemetry/instrumentation/_semconv.py
Show resolved
Hide resolved
opentelemetry-instrumentation/src/opentelemetry/instrumentation/_semconv.py
Show resolved
Hide resolved
opentelemetry-instrumentation/src/opentelemetry/instrumentation/_semconv.py
Show resolved
Hide resolved
opentelemetry-instrumentation/src/opentelemetry/instrumentation/_semconv.py
Show resolved
Hide resolved
opentelemetry-instrumentation/src/opentelemetry/instrumentation/_semconv.py
Show resolved
Hide resolved
opentelemetry-instrumentation/src/opentelemetry/instrumentation/_semconv.py
Show resolved
Hide resolved
ocelotl
reviewed
Apr 17, 2024
opentelemetry-instrumentation/src/opentelemetry/instrumentation/_semconv.py
Outdated
Show resolved
Hide resolved
xrmx
reviewed
Apr 17, 2024
...tation/opentelemetry-instrumentation-wsgi/src/opentelemetry/instrumentation/wsgi/__init__.py
Outdated
Show resolved
Hide resolved
ocelotl
reviewed
Apr 17, 2024
opentelemetry-instrumentation/src/opentelemetry/instrumentation/_semconv.py
Show resolved
Hide resolved
ocelotl
reviewed
Apr 17, 2024
opentelemetry-instrumentation/src/opentelemetry/instrumentation/_semconv.py
Show resolved
Hide resolved
ocelotl
approved these changes
Apr 18, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #2453
Http migration plan for wsgi.
For changes NOT related to span attributes, we simply snap to the new semantic conventions like for span name.
Credits to @lmolkova for the original pr.