-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
added conditional calling of unary_unary
etc functions in _InterceptorChannel
#2484
added conditional calling of unary_unary
etc functions in _InterceptorChannel
#2484
Conversation
@VamsiKrishna1211 care to add a test with updated test requirements so we can actually test it in CI? |
@xrmx Yes sure. |
Cool! tests and an entry in CHANGELOG should be enough |
@xrmx The changes in the PR pertain to Is there any standard way already you guys follow to test these kind of scenarios? |
@VamsiKrishna1211 you can take a look at |
instrumentation/opentelemetry-instrumentation-grpc/test-requirements-1.txt
Outdated
Show resolved
Hide resolved
1defe6b
to
f982fb5
Compare
instrumentation/opentelemetry-instrumentation-grpc/test-requirements-0.txt
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-grpc/test-requirements-1.txt
Outdated
Show resolved
Hide resolved
...elemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/grpcext/_interceptor.py
Show resolved
Hide resolved
...elemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/grpcext/_interceptor.py
Show resolved
Hide resolved
...elemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/grpcext/_interceptor.py
Outdated
Show resolved
Hide resolved
...elemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/grpcext/_interceptor.py
Outdated
Show resolved
Hide resolved
@xrmx Thanks for correcting the |
@VamsiKrishna1211 could you please add a CHANGELOG entry? And fix lint and CLA please |
68faaab
to
56f2bb0
Compare
…and grpcio>=1.63.0 versions
…emetry/instrumentation/grpc/grpcext/_interceptor.py Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
…emetry/instrumentation/grpc/grpcext/_interceptor.py Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
92bfbaa
to
fb9bcc1
Compare
@xrmx Apologies for the delayed changes, was caught up with my full-time work for a while. |
…y12 instrument-grpc
@xrmx Updated the repo with the changes. |
@aabmass Can you look into the MR? We're currently trying to update our packages to their latest version (Official nvidia-triton-client package mainly) while also using open-telemetry. But is causing issues because of the issue attached to this MR. |
…y-python-contrib into bugfix/registered-method-error
Fixes #2483
Type of change
How Has This Been Tested?
Installing the grpc contrib package along with
grpc>=1.63.0
version.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.