Skip to content

Update test_logging.py - #976 #2617

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 2 commits into from
Closed

Update test_logging.py - #976 #2617

wants to merge 2 commits into from

Conversation

the-chandru
Copy link
Contributor

@the-chandru the-chandru commented Jun 18, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Copy link

linux-foundation-easycla bot commented Jun 18, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: the-chandru / name: CC (34a3669)
  • ✅ login: lzchen / name: Leighton Chen (3bd0646)

@lzchen
Copy link
Contributor

lzchen commented Jun 20, 2024

This does not completely address #976, so am removing the "fixes" in the description. Also please update the pr title to reflect what you are trying to do.

@lzchen lzchen added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 20, 2024
@the-chandru
Copy link
Contributor Author

thanks

This does not completely address #976, so am removing the "fixes" in the description. Also please update the pr title to reflect what you are trying to do.

Thanks, I will close this PR and create new PR.

@the-chandru the-chandru deleted the patch-1 branch June 21, 2024 11:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants