Add capture to open file descriptors in system metrics instrumentation #2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
approved these changes
Jul 2, 2024
lzchen
reviewed
Jul 2, 2024
...-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py
Outdated
Show resolved
Hide resolved
xrmx
reviewed
Jul 3, 2024
...-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py
Outdated
Show resolved
Hide resolved
ocelotl
approved these changes
Jul 3, 2024
…rc/opentelemetry/instrumentation/system_metrics/__init__.py Co-authored-by: Leighton Chen <lechen@microsoft.com>
ocelotl
force-pushed
the
num-fds-system-metrics
branch
from
1a9eed7 to
02add2f
Compare
11 tasks
xrmx
pushed a commit
to xrmx/opentelemetry-python-contrib
that referenced
this pull request
Jan 24, 2025
open-telemetry#2652) * add capture to open file descriptors in system metrics instrumentation * fix meter type * fix pypy test * add changelog entry * Update instrumentation/opentelemetry-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py Co-authored-by: Leighton Chen <lechen@microsoft.com> * remove runtiem prefix * update tests --------- Co-authored-by: Leighton Chen <lechen@microsoft.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2562
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.