Add instrumentation for aioredis #569
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 395ede5.
|
@mnbbrown |
|
+1 |
|
+1 |
|
@mnbbrown any chances to get this merged? |
a5r0n
reviewed
Dec 21, 2022
|
|
||
| # We provide extras_require parameter to setuptools.setup later which | ||
| # overwrites the extra_require section from setup.cfg. To support extra_require | ||
| # secion in setup.cfg, we load it here and merge it with the extra_require param. |
There was a problem hiding this comment.
Suggested change
| # secion in setup.cfg, we load it here and merge it with the extra_require param. | |
| # section in setup.cfg, we load it here and merge it with the extra_require param. |
|
@mnbbrown, any chance you can pick this up again? Please leave a comment if you can't. Maybe other contributors can continue your work and submit new pull request. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds instrumentation support for aioredis. It replicates the functionality of the existing
redisinstrumentation.Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.