botocore hooks #679
Merged
botocore hooks #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItayGibel-helios
force-pushed
the
botocore_hooks
branch
from
04bda81 to
f0c9dcb
Compare
owais
reviewed
Sep 15, 2021
...pentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py
Outdated
Show resolved
Hide resolved
ItayGibel-helios
force-pushed
the
botocore_hooks
branch
2 times, most recently
from
b12f5f9 to
47ae9a3
Compare
ItayGibel-helios
force-pushed
the
botocore_hooks
branch
from
47ae9a3 to
93b61b2
Compare
|
@owais - I've applied the change you requested, can you please have a look? |
owais
approved these changes
Sep 30, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
opentelemetry-instrumentation-botocore: added request_hooks response_hooks dictionaries passed as arguments to the instrument method.These dictionaries contain a mapping between AWS service names and callable objects that will be invoked before/after an api call to the respective service
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
added a new unit test, testing the hooks activation
Does This PR Require a Core Repo Change?
Checklist: