Fix a logic bug on parentless spans #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tonybaloney please add a test case for this fix ✌️ |
adamantike
reviewed
Oct 29, 2021
exporter/opentelemetry-exporter-richconsole/src/opentelemetry/exporter/richconsole/__init__.py
Outdated
Show resolved
Hide resolved
|
Added a simple test, any pointers for useful test examples would be welcome. I looked at data dog, but its really complicated! |
owais
approved these changes
Nov 18, 2021
|
@tonybaloney please add a changelog entry |
…y-python-contrib into rich_parent_fix
done |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #771