Skip to content

datadog-apm: deprecate opentelemetry datadog exporter #2517

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Mar 9, 2022

Description

Adds deprecation note to the Datadog Span Exporter example.

Type of change

Please delete options that are not relevant.

  • Documentation change

How Has This Been Tested?

N/A

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR: datadog-apm: deprecate datadog exporter opentelemetry-python-contrib#900

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@mabdinur mabdinur force-pushed the munir/ddtrace/deprecate-ddog-exporter branch from 256fb9b to eb8f486 Compare March 9, 2022 20:45
@mabdinur mabdinur marked this pull request as ready for review March 9, 2022 20:59
@mabdinur mabdinur requested a review from a team March 9, 2022 20:59
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinging @majorgreys as the original author of the DD exporter

Co-authored-by: Alex Boten <alex@boten.ca>
Co-authored-by: Tahir H. Butt <tahir@tahirbutt.com>
@mabdinur mabdinur requested a review from majorgreys March 9, 2022 22:20
@mabdinur mabdinur requested a review from codeboten March 10, 2022 15:36
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is only a doc change, it doesn't need a line in the changelog since the package being deprecated lives in the contrib repo.

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 10, 2022
@mabdinur mabdinur requested a review from codeboten March 10, 2022 18:11
@lzchen lzchen merged commit 7505272 into open-telemetry:main Mar 10, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants