Skip to content

Add min max fields to Histogram #2759

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Add min max fields to Histogram #2759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d53deea
Add min max fields to Histogram
ocelotl Apr 16, 2022
3e8181a
Remove maxdiff
ocelotl Jun 13, 2022
5aa8c6a
Add changelog
ocelotl Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased](https://github.com/open-telemetry/opentelemetry-python/compare/v1.12.0rc1-0.31b0...HEAD)

- Add min/max fields to Histogram
([#2759](https://github.com/open-telemetry/opentelemetry-python/pull/2759))
- `opentelemetry-exporter-otlp-proto-http` Add support for OTLP/HTTP log exporter
([#2462](https://github.com/open-telemetry/opentelemetry-python/pull/2462))
- Fix yield of `None`-valued points
Expand Down
2 changes: 2 additions & 0 deletions ...er-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/metric_exporter/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,8 @@ def _translate_data(
sum=data_point.sum,
bucket_counts=data_point.bucket_counts,
explicit_bounds=data_point.explicit_bounds,
max=data_point.max,
min=data_point.min,
)
pb2_metric.histogram.aggregation_temporality = (
metric.data.aggregation_temporality
Expand Down
10 changes: 10 additions & 0 deletions exporter/opentelemetry-exporter-otlp-proto-grpc/tests/metrics/test_otlp_metrics_exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,8 @@ def test_translate_histogram(self):
explicit_bounds=[10.0, 20.0],
exemplars=[],
flags=pb2.DataPointFlags.FLAG_NONE,
max=18.0,
min=8.0,
)
],
aggregation_temporality=AggregationTemporality.DELTA,
Expand Down Expand Up @@ -782,6 +784,8 @@ def test_translate_multiple_scope_histogram(self):
explicit_bounds=[10.0, 20.0],
exemplars=[],
flags=pb2.DataPointFlags.FLAG_NONE,
max=18.0,
min=8.0,
)
],
aggregation_temporality=AggregationTemporality.DELTA,
Expand Down Expand Up @@ -816,6 +820,8 @@ def test_translate_multiple_scope_histogram(self):
explicit_bounds=[10.0, 20.0],
exemplars=[],
flags=pb2.DataPointFlags.FLAG_NONE,
max=18.0,
min=8.0,
)
],
aggregation_temporality=AggregationTemporality.DELTA,
Expand Down Expand Up @@ -857,6 +863,8 @@ def test_translate_multiple_scope_histogram(self):
explicit_bounds=[10.0, 20.0],
exemplars=[],
flags=pb2.DataPointFlags.FLAG_NONE,
max=18.0,
min=8.0,
)
],
aggregation_temporality=AggregationTemporality.DELTA,
Expand Down Expand Up @@ -898,6 +906,8 @@ def test_translate_multiple_scope_histogram(self):
explicit_bounds=[10.0, 20.0],
exemplars=[],
flags=pb2.DataPointFlags.FLAG_NONE,
max=18.0,
min=8.0,
)
],
aggregation_temporality=AggregationTemporality.DELTA,
Expand Down