Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add metrics base tests #3182

Merged
merged 5 commits into from
Feb 23, 2023
Merged

Conversation

shalevr
Copy link
Member

@shalevr shalevr commented Feb 16, 2023

Description

Move the metrics basic test to TestBase class so each metric instrumentation could use those functions
The functions moved from the sqlalchemy instrumentation test and used for urllib3, urllib, tornado:

open-telemetry/opentelemetry-python-contrib#1645

Refactored from:
#3092

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@srikanthccv srikanthccv added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 21, 2023
@shalevr shalevr force-pushed the Add-metrics-base-tests branch from 03f4a00 to 19c74b1 Compare February 22, 2023 14:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants