Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix probabilility sampler #299

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Fix probabilility sampler #299

merged 2 commits into from
Jul 20, 2020

Conversation

fbogsany
Copy link
Contributor

@fbogsany fbogsany commented Jul 19, 2020

Fixes #298

cc @ericmustin

@fbogsany fbogsany self-assigned this Jul 19, 2020
Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm fwiw 👍

@mwear mwear mentioned this pull request Jul 20, 2020
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting @ericmustin and thanks for fixing @fbogsany!

@mwear mwear merged commit 2499c53 into master Jul 20, 2020
@fbogsany fbogsany deleted the fix_probablility_sampler branch January 13, 2021 19:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProbabilitySampler.sample_trace_id? should account for spec compliant trace_id
3 participants