Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move hyper prometheus example into something runnable #562

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Move hyper prometheus example into something runnable #562

merged 1 commit into from
Jun 2, 2021

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Jun 1, 2021

This change moves the hyper-prometheus example out of the opentelemetry-prometheus, and into the global examples folder.

This is the only example located in a subpackage, making it harder to find.
That example also wasn't executable, making it harder to experiment on. By making the folder a part of the workspace, we can now run cargo run on it and see the behavior.

I've also changed the behavior a little bit to return the metrics only on the /metrics path, which is the usually expected behavior from a Prometheus exporter.

@dmathieu dmathieu requested a review from a team June 1, 2021 15:57
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #562 (b3c3d12) into main (1235682) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #562     +/-   ##
=======================================
- Coverage   54.5%   54.5%   -0.1%     
=======================================
  Files         97      97             
  Lines       8534    8534             
=======================================
- Hits        4659    4658      -1     
- Misses      3875    3876      +1     
Impacted Files Coverage Δ
opentelemetry/src/context.rs 92.1% <0.0%> (-0.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1235682...b3c3d12. Read the comment docs.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍 LGTM!

@jtescher jtescher merged commit fb576b0 into open-telemetry:main Jun 2, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants