Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mention that semantic conventions should be autogenerated #1515

Merged
merged 10 commits into from
Mar 22, 2021
Merged

Mention that semantic conventions should be autogenerated #1515

merged 10 commits into from
Mar 22, 2021

Conversation

rakyll
Copy link
Contributor

@rakyll rakyll commented Mar 8, 2021

Adding a section to semantic conventions to capture the implementation
requirements from the languages.

This is a follow up from the spec SIG model where we
discussed we should ask each language to autogenerate
the semantic conventions keys from the YAML files.

@rakyll rakyll requested review from a team March 8, 2021 20:36
@rakyll rakyll changed the title @rakyll Mention that semantic conventions should be autogenerated Mention that semantic conventions should be autogenerated Mar 8, 2021
specification/overview.md Show resolved Hide resolved
specification/overview.md Outdated Show resolved Hide resolved
specification/overview.md Outdated Show resolved Hide resolved
specification/overview.md Show resolved Hide resolved
Copy link
Contributor Author

@rakyll rakyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL, this is good to review again.

specification/overview.md Outdated Show resolved Hide resolved
specification/overview.md Outdated Show resolved Hide resolved
specification/overview.md Show resolved Hide resolved
@SergeyKanzhelev
Copy link
Member

PR is good as is. It may be worth it to add the note about the way to expose these constant though

Copy link
Contributor Author

@rakyll rakyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

specification/overview.md Outdated Show resolved Hide resolved
rakyll added 8 commits March 19, 2021 16:58
Adding a section to semantic conventions to capture the implementation
requirementes from the languages.

This is a follow up from the spec SIG model where we
discussed we should ask each langauge to autogenerate
the semantic conventions keys from the YAML files.
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bogdandrutu bogdandrutu merged commit 8b9a79e into open-telemetry:main Mar 22, 2021
ThomsonTan pushed a commit to ThomsonTan/opentelemetry-specification that referenced this pull request Mar 30, 2021
…etry#1515)

* Mention that semantic conventions should be autogenerated

Adding a section to semantic conventions to capture the implementation
requirementes from the languages.

This is a follow up from the spec SIG model where we
discussed we should ask each langauge to autogenerate
the semantic conventions keys from the YAML files.

* Add to CHANGELOG

* Fix CHANGELOG

* Fix the link

* markdownlint

* Address feedback

* Address feedback

* Fix typ

* Update overview.md

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
carlosalberto added a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
…etry#1515)

* Mention that semantic conventions should be autogenerated

Adding a section to semantic conventions to capture the implementation
requirementes from the languages.

This is a follow up from the spec SIG model where we
discussed we should ask each langauge to autogenerate
the semantic conventions keys from the YAML files.

* Add to CHANGELOG

* Fix CHANGELOG

* Fix the link

* markdownlint

* Address feedback

* Address feedback

* Fix typ

* Update overview.md

Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants