metrics: Define name syntax #3643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @open-telemetry/go-maintainers |
MrAlias
reviewed
Aug 7, 2023
| ``` | ||
|
|
||
| * They are not null or empty strings. | ||
| * They are case-insensitive, ASCII strings. |
There was a problem hiding this comment.
This will introduce a similar issue to this. I would recommend the meter name syntax not be case-insensitive.
There was a problem hiding this comment.
Do I understand correctly that in order to address this comment I would need to introduce a dedicated section for meter name instead of unifying the name syntax (as we should not make the existing instrument name case-sensitive)?
|
Closing per #3579 (comment). @jack-berg thanks for your comment 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3579
Changes
The existing meter name validation is "underpowered" compared to instrument name validation.
I propose to align and use the same syntax and behavior for both names.
Why
I am not sure what are the exact reasons that are behind the existing instrument name syntax, but I guess the same reasons could be applies to meter name syntax. I think it would make the specification more consistent.