Separate OTLP HTTP and GRPC Exporters #399
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #389
Created three targets: Common, Grpc, and HTTP. The latter two are also products.
The default product (same name as previous) will use Grpc to aide in backwards compatibility.
Clients using HTTP will have to change imports, but given the experimental nature of the current implementation I don't believe this to be a major problem. However, if others disagree we could make the default product include both Grpc and HTTP and then have separate GRPC and HTTP targets for those who specifically only want one.
Updated sample code which proves we're able to drop the NIO and GRPC dependencies. Not done full benchmarks, but locally the sample product does build quicker.
No other changes beyond separation and imports. Basic compile tests done, but not a full integraiton.