Update Semantic Attributes #408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sherlouk
requested review from
nachoBonafonte,
bryce-b and
vvydier
as code owners
|
Looks like CI is failing because the SDK utilises convention values which have been renamed. Just need to do a pass and rename all uses of them - if anybody gets time, feel free to take over and make those tweaks. The script itself is good here though 👍 |
nachoBonafonte
pushed a commit
to nachoBonafonte/opentelemetry-swift
that referenced
this pull request
May 4, 2023
It uses generate.sh and SemanticAttributes.swift.j2 from PR open-telemetry#408 by Sherlouk
Merged
nachoBonafonte
pushed a commit
that referenced
this pull request
May 5, 2023
Update Spec to v1.20.0. It uses generate.sh and SemanticAttributes.swift.j2 from PR #408 by Sherlouk
|
I used the updated script and the template for #409. Thanks a lot for your help |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Slack conversation with Nacho, this patches the current script.