-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Blog: fix typos in APISIX blog #1254
Conversation
Hi @chalin @SergeyKanzhelev , sorry to bother you guys again, could you take a look on this pull request when available, thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for catching those through another careful review of your post. ✨
linkTitle: Apache APISIX-Opentelemetry Integration | ||
date: 2022-03-26 | ||
author: Haochao Zhuang, Fei Han | ||
canonical_url: https://apisix.apache.org/blog/2022/02/28/apisix-integration-opentelemetry-plugin/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure what our policy will be about canonical URLs for regular blog posts (btw, this doesn't set the page's canonical URL yet). I'll bring this up during our next Comms/website meeting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's kind of a long story... This blog is originally written and edited by Fei and Haochao.
Then it is published on Apache APISIX Blog https://apisix.apache.org/blog/2022/02/28/apisix-integration-opentelemetry-plugin
Then I created a pull request for it in OpenTelemetry's repo. #1185
After modifications, it finally gets published on their website. https://opentelemetry.io/blog/2022/apisix/
Finally, I had some voices from the community said that canonical URL should be added, otherwise one of the pages will be downgraded by search engine, which is bad for SEO.
After some discussions in apache/apisix-website#995, we figure the best way to work this out is to add a canonical URL here.
So I read through previous blogs and find canonical_url
as the solution for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it required to add [original post]: {{% param canonical_url %}}
as well to complete the canonical URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can certainly add that to the end of your post, similarly to what was done for https://opentelemetry.io/blog/2022/troubleshooting-nodejs/ (see the end of the page). That is:
A version of this article was originally posted on the Apache APISIX blog.
Using {{% param canonical_url %}}
for the link definition. See https://github.com/open-telemetry/opentelemetry.io/blob/main/content/en/blog/2022/troubleshooting-nodejs.md for an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I get it now, thanks @chalin!
Found some typos as I was going through the blog again.