Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

NServiceBus OpenTelemetry integration #6358

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

irinascurtu
Copy link

No description provided.

@irinascurtu irinascurtu requested a review from a team as a code owner February 17, 2025 10:07
Copy link

linux-foundation-easycla bot commented Feb 17, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@cartermp
Copy link
Contributor

@irinascurtu can you sign the CLA? They we can review.

@irinascurtu
Copy link
Author

@irinascurtu can you sign the CLA? They we can review.

Seems to be fine now

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, I would like @svrnm to weigh in on the type field.

@irinascurtu
Copy link
Author

Looks good to me overall, I would like @svrnm to weigh in on the type field.

I left only instrumentation there

@cartermp
Copy link
Contributor

/fix:all

@opentelemetrybot
Copy link
Collaborator

@cartermp
Copy link
Contributor

@irinascurtu to resolve the issues with registry validation, these are the errors:

Error: An author must have an email or a URL
Error: must match "else" schema
Error: must have required property 'name'
Error: must match "then" schema

Comment on lines 15 to 16
- name: Particular Software
- url: https://github.com/Particular
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Particular Software
- url: https://github.com/Particular
- name: Particular Software
url: https://github.com/Particular
email: contact@particular.net

see @cartermp's comment, this should fix the validation issues

repo: https://github.com/Particular/NServiceBus
docs: https://docs.particular.net/nservicebus/operations/opentelemetry
license: Apache 2.0 # or whatever your OSS license is (see https://opensource.org/licenses/), proprietary or non-OSI approved may be rejected
description: A friendly description of your integration/plugin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: A friendly description of your integration/plugin
description: A friendly description of your integration/plugin

please provide a description

website: https://particular.net/ # to work on the integrations page as well
repo: https://github.com/Particular/NServiceBus
docs: https://docs.particular.net/nservicebus/operations/opentelemetry
license: Apache 2.0 # or whatever your OSS license is (see https://opensource.org/licenses/), proprietary or non-OSI approved may be rejected
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license: Apache 2.0 # or whatever your OSS license is (see https://opensource.org/licenses/), proprietary or non-OSI approved may be rejected
license: Reciprocal Public License 1.5

Please make sure that the right license is set

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants