-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
NServiceBus OpenTelemetry integration #6358
base: main
Are you sure you want to change the base?
Conversation
@irinascurtu can you sign the CLA? They we can review. |
Seems to be fine now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall, I would like @svrnm to weigh in on the type field.
I left only instrumentation there |
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13459162673 |
@irinascurtu to resolve the issues with registry validation, these are the errors:
|
- name: Particular Software | ||
- url: https://github.com/Particular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Particular Software | |
- url: https://github.com/Particular | |
- name: Particular Software | |
url: https://github.com/Particular | |
email: contact@particular.net |
see @cartermp's comment, this should fix the validation issues
repo: https://github.com/Particular/NServiceBus | ||
docs: https://docs.particular.net/nservicebus/operations/opentelemetry | ||
license: Apache 2.0 # or whatever your OSS license is (see https://opensource.org/licenses/), proprietary or non-OSI approved may be rejected | ||
description: A friendly description of your integration/plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: A friendly description of your integration/plugin | |
description: A friendly description of your integration/plugin |
please provide a description
website: https://particular.net/ # to work on the integrations page as well | ||
repo: https://github.com/Particular/NServiceBus | ||
docs: https://docs.particular.net/nservicebus/operations/opentelemetry | ||
license: Apache 2.0 # or whatever your OSS license is (see https://opensource.org/licenses/), proprietary or non-OSI approved may be rejected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license: Apache 2.0 # or whatever your OSS license is (see https://opensource.org/licenses/), proprietary or non-OSI approved may be rejected | |
license: Reciprocal Public License 1.5 |
Please make sure that the right license is set
IMPORTANT: (RE-)RUN
|
No description provided.