Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
  • Loading branch information
jack-berg and trask authored Oct 26, 2023
1 parent eca5212 commit 9a21757
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions buildscripts/templates/SemanticAttributes.java.j2
Original file line number Diff line number Diff line change
Expand Up @@ -670,7 +670,7 @@ public final class {{class}} {
/**
* Immediate client peer port number.
*
* @deprecated This item has renamed in 1.22.0 of the semantic conventions. Use {@link SemanticAttributes#NETWORK_PEER_PORT} instead.
* @deprecated This item has renamed in 1.22.0 of the semantic conventions. Use {@link SemanticAttributes#NETWORK_PEER_PORT} on server telemetry and {@link SemanticAttributes#NETWORK_LOCAL_PORT} on client telemetry instead.
*/
@Deprecated
public static final AttributeKey<Long> CLIENT_SOCKET_PORT = longKey("client.socket.port");
Expand Down Expand Up @@ -708,7 +708,7 @@ public final class {{class}} {
* the socket's peer address, and not attempt to find any actual server IP (i.e., if set from
* client, this may represent some proxy server instead of the logical server).
*
* @deprecated This item has renamed in 1.22.0 of the semantic conventions. Use {@link SemanticAttributes#NETWORK_LOCAL_ADDRESS} instead.
* @deprecated This item has renamed in 1.22.0 of the semantic conventions. Use {@link SemanticAttributes#NETWORK_LOCAL_ADDRESS} on server telemetry and {@link SemanticAttributes#NETWORK_PEER_ADDRESS} on client telemetry instead.
*/
@Deprecated
public static final AttributeKey<String> SERVER_SOCKET_ADDRESS =
Expand Down Expand Up @@ -767,15 +767,15 @@ public final class {{class}} {
/**
* Physical server port.
*
* @deprecated This item has renamed in 1.22.0 of the semantic conventions. Use {@link SemanticAttributes#NETWORK_LOCAL_PORT} instead.
* @deprecated This item has renamed in 1.22.0 of the semantic conventions. Use {@link SemanticAttributes#NETWORK_LOCAL_PORT} on server telemetry and {@link SemanticAttributes#NETWORK_PEER_PORT} on client telemetry instead.
*/
@Deprecated
public static final AttributeKey<Long> SERVER_SOCKET_PORT = longKey("server.socket.port");

/**
* Immediate client peer address - unix domain socket name, IPv4 or IPv6 address.
*
* @deprecated This item has renamed in 1.22.0 of the semantic conventions. Use {@link SemanticAttributes#NETWORK_PEER_ADDRESS} instead.
* @deprecated This item has renamed in 1.22.0 of the semantic conventions. Use {@link SemanticAttributes#NETWORK_PEER_ADDRESS} on server telemetry and {@link SemanticAttributes#NETWORK_LOCAL_ADDRESS} on client telemetry instead.
*/
@Deprecated
public static final AttributeKey<String> CLIENT_SOCKET_ADDRESS =
Expand Down

0 comments on commit 9a21757

Please # to comment.