Exclude namespaces that aren't useful in jvm environments (#54)

* Exclude namespaces that aren't useful in jvm environments * Fix test
open-telemetry · Mar 26, 2024 · ede8688 · ede8688
1 parent 97bf96c
commit ede8688
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 67 deletions.
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -98,6 +98,8 @@ fun generateTask(taskName: String, incubating: Boolean) {
         "--template", "/templates/SemanticAttributes.java.j2",
         "--output", "/output/{{pascal_prefix}}${classPrefix}Attributes.java",
         "--file-per-group", "root_namespace",
+        // Space delimited list of root namespaces to excluded (i.e. "foo bar")
+        "-Dexcluded_namespaces=\"ios\"",
         "-Dfilter=${filter}",
         "-DclassPrefix=${classPrefix}",
         "-Dpkg=$packageNameArg",

diff --git a/buildscripts/templates/SemanticAttributes.java.j2 b/buildscripts/templates/SemanticAttributes.java.j2
@@ -37,7 +37,8 @@
 {%- set filtered_attributes = attributes_and_templates | list %}
 {%- endif %}
 {%- set filtered_enums = filtered_attributes | selectattr('is_enum', 'equalto', true) | list %}
-{%- if filtered_attributes | count > 0 %}
+{%- set excluded_namespaces_list = excluded_namespaces.replace("\"", "").split(' ') %}
+{%- if root_namespace not in excluded_namespaces_list and filtered_attributes | count > 0 %}
 /*
  * Copyright The OpenTelemetry Authors
  * SPDX-License-Identifier: Apache-2.0

diff --git a/...incubating/src/main/java/io/opentelemetry/semconv/incubating/IosIncubatingAttributes.java b/...incubating/src/main/java/io/opentelemetry/semconv/incubating/IosIncubatingAttributes.java
diff --git a/...ubating/src/test/java/io/opentelemetry/semconv/incubating/IncubatingAvailabilityTest.java b/...ubating/src/test/java/io/opentelemetry/semconv/incubating/IncubatingAvailabilityTest.java
@@ -36,7 +36,6 @@ void available() {
     isValidClass("io.opentelemetry.semconv.incubating.HerokuIncubatingAttributes");
     isValidClass("io.opentelemetry.semconv.incubating.HostIncubatingAttributes");
     isValidClass("io.opentelemetry.semconv.incubating.HttpIncubatingAttributes");
-    isValidClass("io.opentelemetry.semconv.incubating.IosIncubatingAttributes");
     isValidClass("io.opentelemetry.semconv.incubating.JvmIncubatingAttributes");
     isValidClass("io.opentelemetry.semconv.incubating.K8sIncubatingAttributes");
     isValidClass("io.opentelemetry.semconv.incubating.LogIncubatingAttributes");