Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update to semconv 1.22 #29

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Update to semconv 1.22 #29

merged 5 commits into from
Oct 26, 2023

Conversation

jack-berg
Copy link
Member

Replaces #27.

@jack-berg jack-berg requested a review from a team October 25, 2023 20:18
@jack-berg jack-berg mentioned this pull request Oct 25, 2023
Closed
@jack-berg
Copy link
Member Author

I've added japcmp to this project to ensure we don't miss anything when manually adding any attributes that have been removed.

trask
trask approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

buildscripts/templates/SemanticAttributes.java.j2 Outdated Show resolved Hide resolved
buildscripts/templates/SemanticAttributes.java.j2 Outdated Show resolved Hide resolved
buildscripts/templates/SemanticAttributes.java.j2 Outdated Show resolved Hide resolved
buildscripts/templates/SemanticAttributes.java.j2 Outdated Show resolved Hide resolved
buildscripts/templates/SemanticAttributes.java.j2 Outdated Show resolved Hide resolved
buildscripts/templates/SemanticAttributes.java.j2 Outdated Show resolved Hide resolved
buildscripts/templates/SemanticAttributes.java.j2 Outdated Show resolved Hide resolved
jack-berg and others added 2 commits October 25, 2023 20:33
@jack-berg @trask
Apply suggestions from code review
9a21757 
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@jack-berg
Fix grammar
58ae276
@jack-berg jack-berg merged commit abe4171 into open-telemetry:main Oct 26, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jack-berg @trask