-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Improvements of the laser envelope extension #281
Conversation
This sounds great. My only thought is, do we want to have a non-binary option instead of
are other options often used in experimental measurements. We could stay extensible if we only standardize a few strings for now:
|
Hm, I think that the name Maybe we could have something more explicit like, |
@ax3l Thanks, I think that, as Remi pointed out, the name @RemiLehe Thanks, this is better indeed. So to check if an openPMD file complies with the |
I made the changes :) |
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
This is great, thank you! :) |
This PR proposes the following improvements to the EXT_LaserEnvelope extension:
isLaserEnvelope
is a required attribute, rather than optional.AttributesisSpatial
contains this info.isNormalized
contains this info.While the first point is minor and the second point has been discussed in the context of LASY, the last point is relatively new. Supporting the normalized vector potential (or at least the SI vector potential) can be important as this is what appears in the ponderomotive force, and what is implemented in envelope solvers. As the conversion from field to vector potential can be non-trivial in a simulation code (it required the knowledge of the local frequency, which comes from a derivative of the phase, and can be cumbersome to implement in a robust way), I believe it is useful for the standard to accept both. An alternative approach would be to add, as an attribute, another array containing the local frequency, so the reconstruction in simulation codes is made easier.