Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixes for building with newlib/cygwin #211

Merged
merged 2 commits into from
Jun 30, 2017
Merged

Fixes for building with newlib/cygwin #211

merged 2 commits into from
Jun 30, 2017

Conversation

jon-turney
Copy link
Contributor

No description provided.

@mlschroe
Copy link
Member

I seem to remember that the cmake folks consider it bad style to include the prefix with the DESTINATION. Would RUNTIME DESTINATION bin also work?

@ignatenkobrain
Copy link
Collaborator

@mlschroe it will, because it is completely same (but still I would rather do #141)

@jon-turney
Add RUNTIME DESTINATION to INSTALL TARGETS
5d2a4dd 
This is needed for shared library runtimes to be installed correctly on DLL
platforms.  It has no effect on other platforms.

v2:
No need to include prefix, since DESTINATION is relative to it
@jon-turney
Copy link
Contributor Author

I seem to remember that the cmake folks consider it bad style to include the prefix with the DESTINATION. Would RUNTIME DESTINATION bin also work?

Makes sense. Done.

@mlschroe mlschroe merged commit 6f92f39 into openSUSE:master Jun 30, 2017
@jon-turney jon-turney mentioned this pull request Jul 30, 2018
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ignatenkobrain ignatenkobrain ignatenkobrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jon-turney @mlschroe @ignatenkobrain