Fix bug #884 - Port How_to_finetune_chat_models to API V1 #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborcselle
changed the title
|
Thank you @gaborcselle ! Yes - rerunning the cells would be great. |
|
Thanks @simonpfish, working on this now! |
|
@simonpfish PTAL |
|
Addendum: This PR also fixes #889 |
|
@simonpfish Friendly ping, would be great to have this fix in! |
|
@simonpfish Sorry to bother you, just another friendly ping on this. I think this would be a useful PR that solves both #884 and #889. I just merged the latest changes. Thanks for reviewing it! |
simonpfish
approved these changes
Dec 5, 2023
katia-openai
pushed a commit
that referenced
this pull request
Feb 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix bug #884 - Migrate
How_to_finetune_chat_models.ipynbto API V1Motivation
The notebook
How_to_finetune_chat_models.ipynbwas no longer working with the API V1 described in the v1.0.0 migration guideTesting info
I tested this manually with Python 3.11.3 and OpenAI Python SDK V1.3.5