Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

Remove devices gracefully when shutting down VMM #273

Closed
justxuewei opened this issue Apr 4, 2023 · 4 comments · Fixed by #277
Closed

Remove devices gracefully when shutting down VMM #273

justxuewei opened this issue Apr 4, 2023 · 4 comments · Fixed by #277

Comments

@justxuewei
Copy link
Contributor

justxuewei commented Apr 4, 2023

The types of devices that should implement gracefully shutting down include:

justxuewei added a commit to justxuewei/dragonball-sandbox that referenced this issue Apr 23, 2023
…k devices

For virtio-net devices, the removed resource is its event hanlder.

For virtio-vsock devices, the removed resources are its event handler
and a socket on the host.

Fixes: openanolis#273

Signed-off-by: Zizheng Bian <zizheng.bian@linux.alibaba.com>
Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
justxuewei added a commit to justxuewei/dragonball-sandbox that referenced this issue Apr 23, 2023
This PR implements functionaility of clearing resources for virtio-net
and virtio-vsock devices.

For virtio-net devices, the removed resource is its event hanlder.

For virtio-vsock devices, the removed resources are its event handler
and a socket on the host.

Fixes: openanolis#273

Signed-off-by: Zizheng Bian <zizheng.bian@linux.alibaba.com>
Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
@justxuewei
Copy link
Contributor Author

#277 implements graceful removal for virtio-net and virtio-vsock devices.

justxuewei added a commit to justxuewei/dragonball-sandbox that referenced this issue Apr 24, 2023
Obtaining reference of unaligned fields is being phased out. Therefore,
`&struct.field` is replaced with `std::ptr::addr_of!(struct.field)` to
avoid those warning issues. For more details, please refer to
rust-lang/rust#82523.

Fixes: openanolis#273

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
studychao pushed a commit that referenced this issue Apr 24, 2023
This PR implements functionaility of clearing resources for virtio-net
and virtio-vsock devices.

For virtio-net devices, the removed resource is its event hanlder.

For virtio-vsock devices, the removed resources are its event handler
and a socket on the host.

Fixes: #273

Signed-off-by: Zizheng Bian <zizheng.bian@linux.alibaba.com>
Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
studychao pushed a commit that referenced this issue Apr 24, 2023
Obtaining reference of unaligned fields is being phased out. Therefore,
`&struct.field` is replaced with `std::ptr::addr_of!(struct.field)` to
avoid those warning issues. For more details, please refer to
rust-lang/rust#82523.

Fixes: #273

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
@justxuewei
Copy link
Contributor Author

@studychao Could you reopen this issue? Because the vhost-net and the virtio-mem haven't implemented this yet.

@studychao studychao reopened this Apr 24, 2023
@studychao
Copy link
Member

@studychao Could you reopen this issue? Because the vhost-net and the virtio-mem haven't implemented this yet.

Done, thanks. Seem like Github will automatically close the issue if related PR is merged..

studychao pushed a commit to studychao/dragonball-sandbox that referenced this issue Jul 7, 2023
This PR implements functionaility of clearing resources for virtio-net
and virtio-vsock devices.

For virtio-net devices, the removed resource is its event hanlder.

For virtio-vsock devices, the removed resources are its event handler
and a socket on the host.

Fixes: openanolis#273

Signed-off-by: Zizheng Bian <zizheng.bian@linux.alibaba.com>
Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
studychao pushed a commit to studychao/dragonball-sandbox that referenced this issue Jul 7, 2023
Obtaining reference of unaligned fields is being phased out. Therefore,
`&struct.field` is replaced with `std::ptr::addr_of!(struct.field)` to
avoid those warning issues. For more details, please refer to
rust-lang/rust#82523.

Fixes: openanolis#273

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
@studychao
Copy link
Member

kata-containers/kata-containers#6684
will be used to track this issue

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
2 participants