Skip to content

feat!: Add an override when creating schemas that include oai.References #1003

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat!: Add an override when creating schemas that include oai.References #1003

wants to merge 3 commits into from

Conversation

wallagib
Copy link

This is a simple PR that replaces the roots of a Schema with the ReferencePath instead of erroring out.

@wallagib
Copy link
Author

@dbanty This code causes one pytest tests to fail. test_skips_references_and_keeps_going, which makes sense, since this PR tries to handle references instead of skipping them. This change feels naive, but I'm not sure what tests I should add to expand on it. Can you offer some guidance?

@wallagib wallagib marked this pull request as ready for review March 22, 2024 16:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wallagib