Skip to content

feat!:Use "Type<Title>" instead of "Type<Index>" if available #962

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wallagib
Copy link

Changed behavior from using the term x_type_0 to x_type_y if x is a Schema that defines a Title property string y.

This provides an easier interface for understanding what users are importing, as well as less reliance on the ordering of the schema.

@wallagib wallagib force-pushed the use-descriptive-type-names branch from 7ba5370 to 725c4c8 Compare February 14, 2024 15:39
@wallagib wallagib changed the title Use "Type<Title>" instead of "Type<Index>" if available feat!:Use "Type<Title>" instead of "Type<Index>" if available Feb 14, 2024
@dbanty dbanty added the 🥚breaking This change breaks compatibility label Feb 19, 2024
@wallagib wallagib force-pushed the use-descriptive-type-names branch from 725c4c8 to 85350a7 Compare February 19, 2024 04:46
@wallagib
Copy link
Author

Force-pushed a linting fix

Changed behavior from using the term `x_type_0` to `x_type_y` if x is a Schema that defines a Title property string `y`.

This provides an easier interface for understanding what users are importing, as well as less reliance on the ordering of the schema.

BREAKING CHANGE: The name of imports will change if the Schema they were built on previously used Title properties on fields within a oneOf Union.
@wallagib wallagib force-pushed the use-descriptive-type-names branch from 85350a7 to 5c93054 Compare February 19, 2024 15:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🥚breaking This change breaks compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants