Support for per-vlan traps #1056
Conversation
|
What if same object is in both the host trap table and this vlan trap table? |
|
As discussed during the meeting can you summarize the reasons for diverging from the behavior of SAI_HOSTIF_TRAP_ATTR_EXCLUDE_PORT_LIST, i.e. why not have have SAI_HOSTIF_TRAP_ATTR_EXCLUDE_VLAN_LIST? |
|
The key to create the SAI_HOSTIF_TRAP object is currently the SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE. The use case where two VLANs that need different behavior for the same trap will not work as is today. |
|
There's a feedback from Matty in sai meeting - packets going to cpu need to be via hostif_trap channel, it cannot be omitted, even though it is meant to be per-vlan trap. @mattyk , please clarify if any. @bandaru-viswanath should address this first. |
Would it make sense to have then a common exclude LIST based on a type where TYPE can be PORT/VLAN/RIF ? |
|
retest this please |
|
+Vissu
This PR will to be closed by the Author.
…-Jai
From: lguohan <notifications@github.com>
Reply-To: opencomputeproject/SAI <reply@reply.github.com>
Date: Friday, May 29, 2020 at 1:33 PM
To: opencomputeproject/SAI <SAI@noreply.github.com>
Cc: Jai Kumar <jai.kumar@broadcom.com>, Comment <comment@noreply.github.com>
Subject: Re: [opencomputeproject/SAI] Support for per-vlan traps (#1056)
retest this please
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Closing this PR as per recommendation. |
Add an ability for the user to specify a list of traps that are applicable (only) for that vlan. This list is in-addition to the traps that are otherwise generally defined.