Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Framework for reconciler implementation. #194

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Framework for reconciler implementation. #194

merged 4 commits into from
Oct 18, 2023

Conversation

robshakir
Copy link
Contributor 

* (M) server/server.go
   - Fix typo
 * (A) rib/reconciler/reconcile(_test)?.go
   - Add initial framework for a reconciler function between two gRIBI
     RIBs. The implementation is incomplete, but this gives a picture of
     the initial design to be iterated on in subsequent PRs.

@robshakir
Framework for reconciler implementation.
9db71ed 
 * (M) server/server.go
   - Fix typo
 * (A) rib/reconciler/reconcile(_test)?.go
   - Add initial framework for a reconciler function between two gRIBI
     RIBs. The implementation is incomplete, but this gives a picture of
     the initial design to be iterated on in subsequent PRs.
@robshakir
Fix lint error.
f0fda55
@robshakir
Add a FakeRIB to simplify testing.
6a99f65 
 * (M) rib/helpers(_test).go
   - Add helper methods for a RIB that allow it to be constructed
     for tests in a simpler fashion.
@robshakir
Add support for retreiving from a remote RIB. (#196)
98e2bf4 
    Add support for retrieving a RIB from a remote source.
    
     * (M) go.{mod,sum}
      - Move to non-release version of ygot to get new `protomap` features.
     * (M) rib/remote.go
      - Add support for a RIB that is accessed via the `Get` RPC rather than
        locally.
     * (M) rib/rib(_test).go
      - Add a mechanism to retrieve RIB contents, improve testing.
@robshakir robshakir merged commit a1124db into main Oct 18, 2023
@robshakir robshakir deleted the reconciler branch October 18, 2023 02:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alshabib alshabib alshabib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robshakir @alshabib