Add support for next-hop-group into reconciler. #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robshakir
commented
Oct 23, 2023
robshakir
commented
* (M) rib/reconciler/reconcile.go
* (M) rib/reconciler/reconcile_test.go
- support add/delete/replace for NextHopGroup entries within a RIB.
alshabib
approved these changes
Oct 23, 2023
* (M) rib/helpers.go
* (M) rib/helpers_test.go
- Allow NH details to be injected into the fake RIB.
* (M) rib/reconciler/reconcile.go
* (M) rib/reconciler/reconcile_test.go
- Restructure return values to allow a caller to stage their
operations into the gRIBI server - e.g., perform adds to install
new entries, then replaces, then deletes. Keep types separate to
allow for more robust ordering.
- Add support for NH diffing.
* (M) rib/reconciler/remote_test.go
- Adopt new fake RIB helper method.
* Add support for MPLS reconciliation.
* (M) rib/helpers.go
* (M) rib/helpers_test.go
- Add fake RIB helper methods for MPLS.
* (M) rib/reconciler/reconcile.go
* (M) rib/reconciler/reconcile_test.go
- Add support for reconciliation of label entries.
* Add support for `ALL` address families in explicitReplace.
* (M) rib/reconciler/reconcile.go
* (M) rib/reconciler/reconcile_test.go
- Ensure that the `ALL` `AFTType` is mapped to the correct address
families when reconciling.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.