rootless: set sticky bit if using XDG_RUNTIME_DIR #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the XDG specification[1], in order to avoid the possibility of our container states being auto-pruned every 6 hours we need to set the sticky bit. Rather than handling all of the users of --root, we just create the directory and set the sticky bit during detection, as it's not expensive. [1]: https://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html Signed-off-by: Aleksa Sarai <asarai@suse.de>
|
LGTM |
1 similar comment
|
LGTM |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the XDG specification1, in order to avoid the possibility of
our container states being auto-pruned every 6 hours we need to set the
sticky bit. Rather than handling all of the users of --root, we just
create the directory and set the sticky bit during detection, as it's
not expensive.
Fixes #1694
Signed-off-by: Aleksa Sarai asarai@suse.de