Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Revert "libcontainer/rootfs_linux: minor cleanup" #1867

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Revert "libcontainer/rootfs_linux: minor cleanup" #1867

merged 1 commit into from
Aug 15, 2018

Conversation

mrunalp
Copy link
Contributor

@mrunalp mrunalp commented Aug 14, 2018

This reverts commit 1b27db6.

Fixes #1866

Signed-off-by: Mrunal Patel mrunalp@gmail.com

@mrunalp
Revert "libcontainer/rootfs_linux: minor cleanup"
26ec8a9 
This reverts commit 1b27db6.

Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
@mrunalp mrunalp mentioned this pull request Aug 14, 2018
Closed
@mrunalp
Copy link
Contributor Author

mrunalp commented Aug 14, 2018

@opencontainers/runc-maintainers PTAL

@hqhq
Copy link
Contributor

hqhq commented Aug 15, 2018 •
edited by caniszczyk
Loading

LGTM
Add some comments would be better.

Approved with PullApprove

@cyphar
Copy link
Member

cyphar commented Aug 15, 2018 •
edited by caniszczyk
Loading

LGTM. Yeah, rootfs_linux really needs some love...

Approved with PullApprove

@cyphar cyphar merged commit 26ec8a9 into opencontainers:master Aug 15, 2018
cyphar added a commit that referenced this pull request Aug 15, 2018
@cyphar
merge branch 'pr-1867'
20aff4f 
  Revert "libcontainer/rootfs_linux: minor cleanup"

LGTMs: @hqhq @cyphar
Closes #1867
@thaJeztah thaJeztah mentioned this pull request Aug 23, 2018
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrunalp @hqhq @cyphar