libcontainer: add /proc/loadavg to the white list of bind mount #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JunLi <lijun.git@gmail.com>
|
As we already know, the file /proc/loadavg in container shows the cpu load of the host, rather than the container. In order to get the cpu load of docker containers, we can use fuse to emulate it as lxcfs did which has added loadavg interface in #237. But we still cann't make it, because we can't mount /proc/loadavg to containers as runc has mount limit for files under /proc. |
|
LGTM. |
|
LGTM |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JunLi lijun.git@gmail.com