Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

features: implement returning potentiallyUnsafeConfigAnnotations list #4217

Merged
merged 1 commit into from
Mar 25, 2024
Merged

features: implement returning potentiallyUnsafeConfigAnnotations list #4217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/spec-conformance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ Spec version | Feature | PR
-------------|------------------------------------------------|----------------------------------------------------------
v1.1.0 | `SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV` | [#3862](https://github.com/opencontainers/runc/pull/3862)
v1.1.0 | `.process.ioPriority` | [#3783](https://github.com/opencontainers/runc/pull/3783)
v1.2.0 | Features: `potentiallyUnsafeConfigAnnotations` | TODO

## Architectures

Expand Down
5 changes: 5 additions & 0 deletions features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@ var featuresCommand = cli.Command{
},
},
},
PotentiallyUnsafeConfigAnnotations: []string{
"bundle",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally forgot about this internal annotation. We should probably see if we can remove it...

(I suspect we also always override it, so it's technically not unsafe but it's better to be safe than sorry.)

"org.systemd.property.", // prefix form
"org.criu.config",
},
}

if seccomp.Enabled {
Expand Down
Loading