Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove unused system.Execv #4268

Merged
merged 2 commits into from
May 8, 2024
Merged

Remove unused system.Execv #4268

merged 2 commits into from
May 8, 2024

Conversation

kolyshkin
Copy link
Contributor

It is not used since commit dac4171.

kolyshkin added 2 commits May 7, 2024 14:09
@kolyshkin
libct/system: rm Execv
dbd0c33 
This is not used since commit dac4171.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
libct: fix a comment
bac5064 
Do not refer to the function which was removed.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin mentioned this pull request May 7, 2024
Merged
@kolyshkin kolyshkin requested a review from lifubang May 7, 2024 23:23
cyphar
cyphar approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cyphar cyphar merged commit 151f480 into opencontainers:main May 8, 2024
40 checks passed
@lifubang lifubang added the backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 label May 9, 2024
@lifubang lifubang mentioned this pull request May 9, 2024
Merged
@kolyshkin kolyshkin added backport/1.1-done A PR in main branch which has been backported to release-1.1 and removed backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 labels May 9, 2024
@kolyshkin kolyshkin mentioned this pull request May 21, 2024
Closed
@lifubang lifubang mentioned this pull request Jun 10, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@cyphar cyphar cyphar approved these changes

@lifubang lifubang Awaiting requested review from lifubang

Assignees
No one assigned
Labels
backport/1.1-done A PR in main branch which has been backported to release-1.1 easy-to-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kolyshkin @cyphar @AkihiroSuda @lifubang