fix a debug msg for user ns in nsexec #4311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lfbzhm <lifubang@acmcoder.com>
lifubang
force-pushed
the
fix-debug-msg-in-nsexec
branch
from
6b9b2c3 to
24c2d28
Compare
|
not sure what's happening with fedora ci, it times out; restarted |
AkihiroSuda
approved these changes
Jun 8, 2024
lifubang
added
the
backport/1.1-todo
lifubang
added
backport/1.1-done
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was using
runc --debugto run a container with user ns, I saw two debug msgsrequest stage-0 to map user namespace, it would make users confused.At the first I thought runc requested stage-0 two times to map user ns? But after looked into the code, there are two same debug msgs in nsexec:
https://github.com/opencontainers/runc/blob/6b9b2c3d/libcontainer/nsenter/nsexec.c#L899