Remove usage of GetMounts from GetCgroupMounts #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
1 similar comment
|
LGTM |
| for scanner.Scan() { | ||
| txt := scanner.Text() | ||
| fields := strings.Split(txt, " ") | ||
| if fields[len(fields)-3] != "cgroup" { |
There was a problem hiding this comment.
Should we use the post separator logic here as it will be more robust?
There was a problem hiding this comment.
@mrunalp what do you mean? :)
There was a problem hiding this comment.
I meant that we can look for the separator -and then match the first word after instead of going minus 3 :) discretionary though :)
Sent from my iPhone
On Jan 30, 2016, at 4:43 AM, Alexander Morozov notifications@github.com wrote:
In libcontainer/cgroups/utils.go:
if mount.Fstype == "cgroup" {- m := Mount{Mountpoint: mount.Mountpoint, Root: mount.Root}
for _, opt := range strings.Split(mount.VfsOpts, ",") {if strings.HasPrefix(opt, cgroupNamePrefix) {m.Subsystems = append(m.Subsystems, opt[len(cgroupNamePrefix):])}if allMap[opt] {m.Subsystems = append(m.Subsystems, opt)}- var res []Mount
- scanner := bufio.NewScanner(f)
- for scanner.Scan() {
txt := scanner.Text()fields := strings.Split(txt, " ")if fields[len(fields)-3] != "cgroup" {—
Reply to this email directly or view it on GitHub.
GetMounts is very cpu-expensive. I'll change other funcs in this package to reuse code from GetCgroupMounts later. Signed-off-by: Alexander Morozov <lk4d4@docker.com>
|
@mrunalp I added optimization with "-" and also added test and benchmark. |
|
Thanks. LGTM. |
crosbymichael
added a commit
that referenced
this pull request
Feb 4, 2016
Remove usage of GetMounts from GetCgroupMounts
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
Correction to User struct in specs-go/config.json
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetMounts is very cpu-expensive. I'll change other funcs in this package
to reuse code from GetCgroupMounts later.