Ocrvs 3051 Possible fix for logo and signature not appearing

[tahmidrahman-dsi]

Bump pdfmake upto 0.2.5

According to this comment bpampuch/pdfmake#1832 (comment) hope it fixes the black background issue, as we render images inside a patten in svg

[codecov]

Codecov Report

Merging #3243 (921d21a) into develop (50d2fc1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #3243   +/-   ##
========================================
  Coverage    79.89%   79.89%           
========================================
  Files          608      608           
  Lines        27876    27876           
  Branches      8860     8860           
========================================
  Hits         22271    22271           
  Misses        5551     5551           
  Partials        54       54           

Impacted Files	Coverage Δ
packages/client/src/offline/reducer.ts	79.86% <ø> (ø)
...ges/client/src/views/DataProvider/birth/queries.ts	66.66% <ø> (ø)
...ges/client/src/views/DataProvider/death/queries.ts	83.33% <ø> (ø)
...ages/client/src/views/PrintCertificate/PDFUtils.ts	89.70% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb4ce38...921d21a. Read the comment docs.

[cypress]

---

Test summary

25 • 4 • 0 • 0 • 1

---

Run details

Project	OpenCRVS Core
Status	Failed
Commit	a325785 ℹ️
Started	May 27, 2022 4:51 PM
Ended	May 27, 2022 5:29 PM
Duration	38:08 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 101

View run in Cypress Dashboard ➡️

---

Failures

	birth.spec.ts		3
1	Birth Integration Test > login as registrar and register declaration with maximum input
2	Birth Integration Test > login as registrar to register minimum input declaration
3	Birth Integration Test > login as registrar & register "Someone else" declaration
	death.spec.ts		1
1	Death Integration Test > Login as registrar to register maximum input death declaration

---

Flakiness

	cypress/integration/certificate.spec.ts		1
1	Certificate Integration Test > Prints minimum input declaration showing the pdf form

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[rikukissa]

@tahmidrahman-dsi are these changes meant to be in this PR?

[tahmidrahman-dsi]

Actually these changes weren't meant to be in this PR. While I was trying to fix the certificate issue, I noticed the registration location name is empty in the certificate (the registrationLocation handlebar is not working as it should) and I figured that recently the certificate query has been changed to fetchBirthRegistration from fetchBirthRegistrationForCertificate which had office fields. So I added these fields and now the registrationLocation handlebar is working.