python QR code benchmark #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksandrPanov
force-pushed
the
QR_bencmark
branch
from
29eb497 to
4c90b9b
Compare
AleksandrPanov
changed the title
asmorkalov
reviewed
Jun 10, 2022
alalek
reviewed
Jun 10, 2022
AleksandrPanov
force-pushed
the
QR_bencmark
branch
from
4c90b9b to
33fde57
Compare
asmorkalov
reviewed
Jun 15, 2022
| for line in f.readlines(): | ||
| try: | ||
| f_list = [float(i) for i in line.split(" ")] | ||
| corners += f_list |
There was a problem hiding this comment.
I propose to add at least array size check to validate integrity and parsing issues.
There was a problem hiding this comment.
return np.array(corners).reshape(-1, 4, 2) made array size check.
Do you suggest adding a manual check?
There was a problem hiding this comment.
I propose to add explicit check with verbose error message.
asmorkalov
reviewed
Jun 15, 2022
added 2 commits
June 21, 2022 18:56
AleksandrPanov
force-pushed
the
QR_bencmark
branch
from
42699f1 to
2960bf6
Compare
asmorkalov
reviewed
Jun 22, 2022
added 2 commits
June 22, 2022 20:14
AleksandrPanov
force-pushed
the
QR_bencmark
branch
from
285a081 to
772a07b
Compare
asmorkalov
reviewed
Jun 27, 2022
AleksandrPanov
force-pushed
the
QR_bencmark
branch
from
bb1d315 to
47fd5c0
Compare
asmorkalov
approved these changes
Jun 29, 2022
| for line in f.readlines(): | ||
| try: | ||
| f_list = [float(i) for i in line.split(" ")] | ||
| corners += f_list |
There was a problem hiding this comment.
I propose to add explicit check with verbose error message.
| corners = image_info.getNode("corners").mat() | ||
| decoded_info = image_info.getNode("decoded_info") | ||
| if not decoded_info.empty(): | ||
| for i in range(decoded_info.size()): |
There was a problem hiding this comment.
Please remove the dead code.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.